fix: inherit blocked status through parent hierarchy (Refs: beans-8mhc)#93
Open
teal-bauer wants to merge 1 commit intohmans:mainfrom
Open
fix: inherit blocked status through parent hierarchy (Refs: beans-8mhc)#93teal-bauer wants to merge 1 commit intohmans:mainfrom
teal-bauer wants to merge 1 commit intohmans:mainfrom
Conversation
Children of blocked parents now show as blocked too. FindActiveBlockers walks up the parent chain and includes ancestor blockers in the result. Refs: beans-8mhc
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Approach 1 for #92: children inherit their parent's blocked status.
FindActiveBlockersnow walks up the parent chain after checking direct blockersIsBlockedreturns true transitively — no API changes neededSimple and opinionated: if your parent is blocked, you're blocked.
Trade-offs
See #92 for design discussion and the alternative approach in #94.
Test plan
go test ./...passes