feat: format user provided TXT records when not quoted #1208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1208 +/- ##
==========================================
- Coverage 72.37% 67.15% -5.23%
==========================================
Files 311 311
Lines 11386 11407 +21
==========================================
- Hits 8241 7660 -581
- Misses 2203 2734 +531
- Partials 942 1013 +71
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f8e7dde to
644d7c6
Compare
apricote
approved these changes
Oct 30, 2025
Member
apricote
left a comment
There was a problem hiding this comment.
Looks good besides the pending release of hcloud-go.
Do we want to mention this in the help pages of the commands?
ddd1b19 to
4b53c75
Compare
apricote
approved these changes
Oct 30, 2025
If the given TXT records are not already quoted, the CLI will split the records into chunks of 255 chars and quote them: ```diff -hcloud zone rrset add-records example-1948294840.com @ TXT --record "\"v=spf1 include:_spf.example.net ~all\"" +hcloud zone rrset add-records example-1948294840.com @ TXT --record "v=spf1 include:_spf.example.net ~all" ```
4b53c75 to
60473d6
Compare
jooola
pushed a commit
that referenced
this pull request
Nov 7, 2025
<!-- section-start changelog --> ### Features - format user provided TXT records when not quoted (#1208) ### Bug Fixes - more readable default time format (#1197) - **iso**: broken `--type` flag in list command (#1221) - Storage Boxes not listed in `hcloud all list` (#1222) - consistent tab spacing in describe commands (#1216) - filepaths not correctly resolved on Windows (#1229) <!-- section-end changelog --> --- <details> <summary><h4>PR by <a href="https://github.com/apricote/releaser-pleaser">releaser-pleaser</a> 🤖</h4></summary> If you want to modify the proposed release, add you overrides here. You can learn more about the options in the docs. ## Release Notes ### Prefix / Start This will be added to the start of the release notes. ~~~~rp-prefix ~~~~ ### Suffix / End This will be added to the end of the release notes. ~~~~rp-suffix ~~~~ </details> Co-authored-by: Hetzner Cloud Bot <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the given TXT records are not already quoted, the CLI will split the records into chunks of 255 chars and quote them: