Skip to content

Conversation

@apricote
Copy link
Member

  • Bump hcloud-go to latest version in branch storage-boxes and fix any issues.
  • Use the default-ssh-keys Options also for Storage Box SSH Keys.

@apricote apricote self-assigned this Oct 20, 2025
@apricote apricote requested a review from a team as a code owner October 20, 2025 14:03
@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

❌ Patch coverage is 84.09091% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.61%. Comparing base (71e3024) to head (625da89).
⚠️ Report is 1 commits behind head on storage-boxes.

Files with missing lines Patch % Lines
internal/cmd/storagebox/create.go 56.25% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           storage-boxes    #1200      +/-   ##
=================================================
+ Coverage          69.51%   69.61%   +0.09%     
=================================================
  Files                311      311              
  Lines              14032    13989      -43     
=================================================
- Hits                9755     9738      -17     
+ Misses              3331     3309      -22     
+ Partials             946      942       -4     
Flag Coverage Δ
e2e 49.49% <13.63%> (+0.16%) ⬆️
unit 64.27% <84.09%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@apricote apricote merged commit af147d8 into storage-boxes Oct 20, 2025
6 checks passed
@apricote apricote deleted the storage-boxes-fixes branch October 20, 2025 14:34
apricote added a commit that referenced this pull request Oct 21, 2025
- Bump `hcloud-go` to latest version in branch `storage-boxes` and fix
any issues.
- Use the `default-ssh-keys` Options also for Storage Box SSH Keys.
apricote added a commit that referenced this pull request Oct 21, 2025
- Bump `hcloud-go` to latest version in branch `storage-boxes` and fix
any issues.
- Use the `default-ssh-keys` Options also for Storage Box SSH Keys.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants