Skip to content

fix: more readable default time format #1197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
apricote merged 3 commits into from
Oct 30, 2025
Merged

fix: more readable default time format #1197

apricote merged 3 commits into from
Oct 30, 2025

Conversation

@apricote
Copy link
Member

@apricote apricote commented Oct 16, 2025

Changes the time format from time.UnixDate to time.DateTime + timezone.

  • Old: Mon Jan 10 15:04:05 MST 2006
  • New: 2006-01-10 15:04:05 MST

I personally find this much easier to read.

@apricote
fix: more readable default time format
722c5c7 
Changes the time format from `time.UnixDate` to `time.DateTime +
timezone`.

- Old: `Mon Jan 10 15:04:05 MST 2006`
- New: `2006-01-10 15:04:05 MST`
@apricote apricote self-assigned this Oct 16, 2025
@apricote apricote requested a review from a team as a code owner October 16, 2025 08:30
@lukasmetzner
Copy link
Contributor

lukasmetzner commented Oct 16, 2025

👍 on the time format

@phm07
Copy link
Contributor

phm07 commented Oct 17, 2025

+1 from me as well.
Is this a breaking change?

@codecov
Copy link

codecov bot commented Oct 17, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.78%. Comparing base (7aeee17) to head (246a41e).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1197      +/-   ##
==========================================
+ Coverage   69.76%   69.78%   +0.02%     
==========================================
  Files         271      271              
  Lines       12302    12302              
==========================================
+ Hits         8582     8585       +3     
+ Misses       2913     2911       -2     
+ Partials      807      806       -1
Flag Coverage Δ
e2e 52.40% <100.00%> (+0.02%) ⬆️
unit 63.90% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@apricote
Copy link
Member Author

apricote commented Oct 17, 2025

Is this a breaking change?

In theory yes, as is every new property we add to describe or list outputs.

I hope no one was parsing the old format.

Maybe we should make it a global option and change the default? Then anyone can move back to the old format if they want to.

@phm07
Copy link
Contributor

phm07 commented Oct 17, 2025

I think a date format option would be a little overkill. It is probably safe to assume that users use JSON or YAML formats when working with raw data.

@apricote apricote merged commit 43c3d39 into main Oct 30, 2025
6 checks passed
@apricote apricote deleted the default-time-format branch October 30, 2025 12:21
@hcloud-bot hcloud-bot mentioned this pull request Oct 30, 2025
Merged
@jooola
Copy link
Member

jooola commented Oct 30, 2025 •
edited
Loading

I think we missed a rebase for this PR before merging: https://github.com/hetznercloud/cli/actions/runs/18940519844/job/54077878135#step:4:819

@apricote
Copy link
Member Author

apricote commented Oct 30, 2025

Ack, will fix it.

apricote added a commit that referenced this pull request Oct 30, 2025
@apricote
test: fix conflicts from new date format
743e9ae 
The PR for the new date format (#1197) was not rebased before merging,
and the tests new storage box commands that were added in the meantime still verified the old date format.
@apricote apricote mentioned this pull request Oct 30, 2025
Merged
@apricote
Copy link
Member Author

apricote commented Oct 30, 2025

-> #1220

apricote added a commit that referenced this pull request Oct 30, 2025
@apricote
test: fix conflicts from new date format (#1220)
074234a 
The PR for the new date format (#1197) was not rebased before merging,
and the tests new storage box commands that were added in the meantime
still verified the old date format.
jooola pushed a commit that referenced this pull request Nov 7, 2025
@hcloud-bot
chore(main): release v1.56.0 (#1219)
c9ebdf3 
<!-- section-start changelog -->
### Features

- format user provided TXT records when not quoted (#1208)

### Bug Fixes

- more readable default time format (#1197)
- **iso**: broken `--type` flag in list command (#1221)
- Storage Boxes not listed in `hcloud all list` (#1222)
- consistent tab spacing in describe commands (#1216)
- filepaths not correctly resolved on Windows (#1229)

<!-- section-end changelog -->

---

<details>
<summary><h4>PR by <a
href="https://github.com/apricote/releaser-pleaser">releaser-pleaser</a>
🤖</h4></summary>

If you want to modify the proposed release, add you overrides here. You
can learn more about the options in the docs.

## Release Notes

### Prefix / Start

This will be added to the start of the release notes.

~~~~rp-prefix
~~~~

### Suffix / End

This will be added to the end of the release notes.

~~~~rp-suffix
~~~~

</details>

Co-authored-by: Hetzner Cloud Bot <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phm07 phm07 phm07 approved these changes

Assignees

@apricote apricote

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@apricote @lukasmetzner @phm07 @jooola