Skip to content

Conversation

@phm07
Copy link
Contributor

@phm07 phm07 commented Oct 10, 2025

Sometimes the JSON output after creating a resource was outdated, because the resource needed to be fetched again. This could happen for example after protection was enabled or the state of a resource changed after waiting for the create action.

Fixes #1167

@phm07 phm07 self-assigned this Oct 10, 2025
@phm07 phm07 requested a review from a team as a code owner October 10, 2025 12:22
@phm07 phm07 added the bug label Oct 10, 2025
@codecov
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

❌ Patch coverage is 26.66667% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.73%. Comparing base (ff8f207) to head (80b1af1).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
internal/cmd/floatingip/create.go 25.00% 4 Missing and 2 partials ⚠️
internal/cmd/network/create.go 14.28% 4 Missing and 2 partials ⚠️
internal/cmd/primaryip/create.go 25.00% 4 Missing and 2 partials ⚠️
internal/cmd/server/create.go 33.33% 3 Missing and 3 partials ⚠️
internal/cmd/volume/create.go 25.00% 4 Missing and 2 partials ⚠️
internal/cmd/loadbalancer/create.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1194      +/-   ##
==========================================
+ Coverage   63.98%   69.73%   +5.74%     
==========================================
  Files         271      271              
  Lines       12262    12290      +28     
==========================================
+ Hits         7846     8570     +724     
+ Misses       3550     2913     -637     
+ Partials      866      807      -59     
Flag Coverage Δ
e2e 52.33% <13.33%> (?)
unit 63.87% <26.66%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@phm07 phm07 merged commit d7b0740 into main Oct 15, 2025
7 checks passed
@phm07 phm07 deleted the fix-create-json-output branch October 15, 2025 08:05
apricote pushed a commit that referenced this pull request Oct 21, 2025
### Storage Box API Experimental

This release adds support for the [Storage Box
API](https://docs.hetzner.cloud/reference/hetzner#storage-boxes).

The Storage Box integration will be introduced as an **experimental**
feature. This experimental phase is expected to last until **21 November
2025**. During this period, upcoming minor releases of the project may
include breaking changes to features related to the Storage Box API. You
can find out the current state of this in
[#1202](#1202).

This release includes all changes from the recent [Storage Box API
changelog](https://docs.hetzner.cloud/changelog#2025-10-21-storage-box-api-update)
entry.

#### Examples

```shell
hcloud storage-box create \
    --name backups \
    --type bx11 \
    --location fsn1 \
    --password "$PASSWORD" \
    --enable-ssh \
    --reachable-externally

hcloud storage-box enable-snapshot-plan backups \
    --max-snapshots 10 \
    --minute 0 \
    --hour 2
```

### Features

- **server,load-balancer**: add --ip-range argument to attach-to-network
commands (#1164)
- add support for Storage Boxes (#1118)

### Bug Fixes

- list commands print `null` instead of `[]` in JSON mode (#1191)
- outdated JSON output after creating resources (#1194)
- formatting of server-type describe output (#1196)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Newly-created volume is reported to have a status of creating

3 participants