fix: propagate focused pane moves to attached clients

[akbash-bot]

Issue

Running herdr pane move ... --focus moves the pane but leaves attached clients on the source workspace. The next client interaction can restore server focus to that old location.

Problem

The server updates its own focus after moving the pane. Public request handling does not copy that destination to attached clients, unlike other public focus commands.

How did we fix it?

Herdr now moves every attached shell client to the destination after a successful, changed pane move requesting focus. It also reconciles locations removed by the move, even when workspace and tab indices stay unchanged. Failed moves, unchanged moves, and --no-focus do not trigger this focus update.

Verification

Before the fix, a regression test observed server focus on w2 while the client remained on w1. Afterward, the client snapshot selects the moved pane and subsequent input reaches its terminal without reverting focus. Tests also cover multiple clients, source removal, unchanged indices, and focus guards.

just check passes on the refreshed upstream base: 3,584 Rust tests, Windows lint, maintenance, integration, and docs checks.

refs #4153

[coderabbitai]

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)

• ai-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: 0472a853-d9f0-4637-bcb0-93016cb9a23f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: 825d782e-6c03-4ec6-860c-805664e5e4ab

📥 Commits

Reviewing files that changed from the base of the PR and between 052779c and 1a36e5e.

📒 Files selected for processing (4)

• src/server/headless/client_views.rs
• src/server/headless/notifications.rs
• src/server/headless/tests/mod.rs
• src/server/headless/tests/pane_move.rs

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

---

📝 Walkthrough

Walkthrough

forward_proxied_api_response now returns parsed API results. Focused PaneMove requests use move_result.changed to determine focus success and trigger shell-client reconciliation. Worktree completion handling converts the forwarding result to a boolean. New headless tests cover focused moves, source removal, unchanged targets, invalid targets, and client-view preservation.

Suggested reviewers: ogulcancelik

Priority: ➖ Normal

Merge Risk: ⚪ Minimal · up to 1a36e

The focused pane-move behavior and guarded no-effect cases have targeted coverage, with no actionable risk remaining.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 62.50% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 4 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: propagating focused pane moves to attached clients.
Description check	✅ Passed	The description directly explains the focused pane move issue, the implementation, and the verification coverage.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[kangal-bot]

@coderabbitai review
@greptileai

[coderabbitai]

@kangal-bot: I will review the changes.

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[greptile-apps]

Confidence Score: 5/5

The PR appears safe to merge, with focused pane moves correctly propagated to attached shell clients and guarded against failed, unchanged, and non-focused moves.

Summary

This PR synchronizes attached shell clients with the server after a successful focused pane move.

• Exposes the proxied API response result so pane moves can be distinguished from unchanged or failed operations.
• Redirects attached shell clients only when a focused pane move reports an effective structural change.
• Reconciles client locations after topology-changing moves, including cases where numeric workspace or tab coordinates remain unchanged.
• Adds regression coverage for multiple clients, source removal, input routing, failed moves, unchanged moves, and --no-focus.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Public PaneMove request] --> B{focus requested?}
    B -- No --> C[Handle move normally]
    B -- Yes --> D[Proxy API response]
    D --> E[Handle pane move]
    E --> F{Successful result with changed=true?}
    F -- No --> G[Forward response without changing client views]
    F -- Yes --> H[Focus shell clients on server destination]
    H --> I[Reconcile client workspace and tab locations]
    I --> J[Render snapshots and route input to moved pane]

Loading

_{Reviews (1) · Last reviewed commit: "fix: propagate focused pane moves to att..."}

[akbash-bot]

Regarding the docstring-coverage advisory: I am keeping the private test helpers and descriptive regression-test names as-is rather than adding comments that repeat their names and assertions. This change adds no public API, and the request handler and unchanged-move focus guard already explain the relevant behavior.

[JJLiebig]

Qualified current head locally on Windows, waiting for Akbash qualification on unix.
lgtm after that