Skip to content

Fix indentation for WatchUntilReady method #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mavimo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix indentation for WatchUntilReady method #431

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix indentation for WatchUntilReady method 
Updated the WatchUntilReady method signature in the Waiter interface.

Signed-off-by: Marco Vito Moscaritolo <mavimo@gmail.com>
  • Loading branch information
@mavimo
mavimo authored Feb 16, 2026
commit 4f16d2bb9911ebeb8ae3415d50a4265cd74cc9a6
4 changes: 2 additions & 2 deletions hips/hip-0022.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ type Waiter interface {
Wait(resources ResourceList, timeout time.Duration) error
WaitWithJobs(resources ResourceList, timeout time.Duration) error
WaitForDelete(resources ResourceList, timeout time.Duration) error
WatchUntilReady(resources ResourceList, timeout time.Duration) error
WatchUntilReady(resources ResourceList, timeout time.Duration) error
}
```

Expand Down Expand Up @@ -111,4 +111,4 @@ seen here - https://github.com/helm/helm/pull/13604

existing wait documentation - https://helm.sh/docs/intro/using_helm/
kstatus documentation - https://github.com/kubernetes-sigs/cli-utils/blob/master/pkg/kstatus/README.md
Zarf kstatus implementation - https://github.com/zarf-dev/zarf/blob/main/src/internal/healthchecks/healthchecks.go
Zarf kstatus implementation - https://github.com/zarf-dev/zarf/blob/main/src/internal/healthchecks/healthchecks.go