Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

[stable/nextcloud] deprecate nextcloud helm chart - #23627

Merged
k8s-ci-robot merged 2 commits into
helm:masterfrom
billimek:deprecate_nextcloud
Aug 31, 2020
Merged

[stable/nextcloud] deprecate nextcloud helm chart#23627
k8s-ci-robot merged 2 commits into
helm:masterfrom
billimek:deprecate_nextcloud

Conversation

@billimek

@billimek billimek commented Aug 27, 2020

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:

This deprecates the nextcloud chart and references the new home.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@billimek
deprecate nextcloud helm chart
04cc4f5 
Signed-off-by: Jeff Billimek <jeff@billimek.com>
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Aug 27, 2020
@helm-bot helm-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 27, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2020
@billimek billimek mentioned this pull request Aug 27, 2020
Closed
@billimek

billimek commented Aug 27, 2020

Copy link
Copy Markdown
Collaborator Author

/assign @scottrigby

scottrigby
scottrigby suggested changes Aug 28, 2020
View reviewed changes

@scottrigby scottrigby left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍 just a few comments

Comment thread stable/nextcloud/Chart.yaml Outdated
Comment thread stable/nextcloud/README.md
@scottrigby

scottrigby commented Aug 28, 2020

Copy link
Copy Markdown
Member

Added link to this PR in #21103

@scottrigby scottrigby changed the title [nextcloud] deprecate nextcloud helm chart [stable/nextcloud] deprecate nextcloud helm chart Aug 28, 2020
@billimek
add additional deprecation language
ea38075 
Signed-off-by: Jeff Billimek <jeff@billimek.com>
scottrigby
scottrigby approved these changes Aug 31, 2020
View reviewed changes

@scottrigby scottrigby left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@billimek looks good! Should we wait to merge this until after nextcloud/helm#7 is finished?

@billimek

billimek commented Aug 31, 2020

Copy link
Copy Markdown
Collaborator Author

@billimek looks good! Should we wait to merge this until after nextcloud/helm#7 is finished?

That should be completed now, I think we are safe to merge. Appreciate the help and guidance!

@scottrigby

scottrigby commented Aug 31, 2020

Copy link
Copy Markdown
Member

/lgtm

@k8s-ci-robot

k8s-ci-robot commented Aug 31, 2020

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: billimek, scottrigby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2020
@k8s-ci-robot
k8s-ci-robot merged commit a314ffb into helm:master Aug 31, 2020
@scottrigby scottrigby mentioned this pull request Jan 20, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chrisingenhaag chrisingenhaag Awaiting requested review from chrisingenhaag
1 more reviewer
@scottrigby scottrigby scottrigby approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@scottrigby scottrigby

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@billimek @scottrigby @k8s-ci-robot @helm-bot