Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

[stable/concourse] Deprecate the stable/concourse chart - #19128

Merged
k8s-ci-robot merged 1 commit into
helm:masterfrom
concourse:deprecate-stable-concourse
Nov 26, 2019
Merged

[stable/concourse] Deprecate the stable/concourse chart#19128
k8s-ci-robot merged 1 commit into
helm:masterfrom
concourse:deprecate-stable-concourse

Conversation

@taylorsilva

@taylorsilva taylorsilva commented Nov 25, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

This PR deprecates the stable/concourse chart. Future development of this chart is happening at github.com/concourse/concourse-chart

Which issue this PR fixes

fixes #18781

Checklist

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@cirocosta @YoussB

@taylorsilva
Deprecate the stable/concourse chart
ddf8103 
Future development is now at github.com/concourse/concourse-chart

Signed-off-by: Taylor Silva <tsilva@pivotal.io>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 25, 2019
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 25, 2019
@k8s-ci-robot

k8s-ci-robot commented Nov 25, 2019

Copy link
Copy Markdown
Contributor

Hi @taylorsilva. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cirocosta

cirocosta commented Nov 25, 2019

Copy link
Copy Markdown
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 25, 2019
@scottrigby

scottrigby commented Nov 26, 2019

Copy link
Copy Markdown
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2019
@k8s-ci-robot

k8s-ci-robot commented Nov 26, 2019

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: scottrigby, taylorsilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2019
@k8s-ci-robot
k8s-ci-robot merged commit 5127ffc into helm:master Nov 26, 2019
@cirocosta
cirocosta deleted the deprecate-stable-concourse branch November 26, 2019 23:53
crmarques pushed a commit to crmarques/charts that referenced this pull request Nov 29, 2019
@taylorsilva Carlos Roberto Marques Junior
Deprecate the stable/concourse chart (helm#19128)
c5d280d 
Future development is now at github.com/concourse/concourse-chart

Signed-off-by: Taylor Silva <tsilva@pivotal.io>
Signed-off-by: Carlos Roberto Marques Junior <carlos.marques@bndes.gov.br>
hakman pushed a commit to hakman/charts that referenced this pull request Dec 5, 2019
@taylorsilva Ciprian Hacman
Deprecate the stable/concourse chart (helm#19128)
a669a52 
Future development is now at github.com/concourse/concourse-chart

Signed-off-by: Taylor Silva <tsilva@pivotal.io>
dargolith pushed a commit to dargolith/charts that referenced this pull request Jan 10, 2020
@taylorsilva @dargolith
Deprecate the stable/concourse chart (helm#19128)
aa2de65 
Future development is now at github.com/concourse/concourse-chart

Signed-off-by: Taylor Silva <tsilva@pivotal.io>
@scottrigby scottrigby mentioned this pull request Jan 20, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@william-tran william-tran Awaiting requested review from william-tran
@YoussB YoussB Awaiting requested review from YoussB
1 more reviewer
@scottrigby scottrigby scottrigby approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[stable/concourse] Move concourse chart out of this repo

5 participants

@taylorsilva @k8s-ci-robot @cirocosta @scottrigby @helm-bot