Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

stable/cert-manager: deprecate cert-manager chart - #12970

Merged
k8s-ci-robot merged 1 commit into
helm:masterfrom
munnerz:deprecate-cert-manager
Apr 12, 2019
Merged

stable/cert-manager: deprecate cert-manager chart#12970
k8s-ci-robot merged 1 commit into
helm:masterfrom
munnerz:deprecate-cert-manager

Conversation

@munnerz

@munnerz munnerz commented Apr 10, 2019

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:

Deprecates the cert-manager chart in favour of the new chart hosted by Jetstack on Helm Hub.

Checklist

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Apr 10, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2019
@helm-bot helm-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 10, 2019
Signed-off-by: James Munnelly <james@munnelly.eu>
@munnerz
munnerz force-pushed the deprecate-cert-manager branch from d636bad to ad97c21 Compare April 10, 2019 13:40
maintainers:
- name: munnerz
email: james@jetstack.io
# Deprecated charts cannot have maintainers

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@unguiculus this feels like a weird requirement, but the e2e checker fails if I leave maintainers here 😬

@munnerz

munnerz commented Apr 10, 2019

Copy link
Copy Markdown
Collaborator Author

According to the Helm chart docs, after this version of the chart is published to the stable repo, we should also remove this chart from the repository altogether. Is that still correct? https://helm.sh/docs/developing_charts/#deprecating-charts


When managing charts in a Chart Repository, it is sometimes necessary to deprecate a chart. The optional deprecated field in Chart.yaml can be used to mark a chart as deprecated. If the latest version of a chart in the repository is marked as deprecated, then the chart as a whole is considered to be deprecated. The chart name can later be reused by publishing a newer version that is not marked as deprecated. The workflow for deprecating charts, as followed by the helm/charts project is:

  • Update chart’s Chart.yaml to mark the chart as deprecated, bumping the version
  • Release the new chart version in the Chart Repository
  • Remove the chart from the source repository (e.g. git)

@munnerz

munnerz commented Apr 12, 2019

Copy link
Copy Markdown
Collaborator Author

Tests here are failing as the chart e2e test cluster doesn't have the cert-manager CRDs installed (this is a recurring problem 🙈)

@prydonius any chance you can re-create these resources so we can get this (final!) PR merged? 😄

@munnerz

munnerz commented Apr 12, 2019

Copy link
Copy Markdown
Collaborator Author

(... plus a /lgtm and a /retest shortly afterwards, so that this actually makes it in before the cluster gets recycled again 😅)

@unguiculus

Copy link
Copy Markdown
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2019
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: munnerz, unguiculus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@unguiculus

Copy link
Copy Markdown
Member

/retest

@k8s-ci-robot
k8s-ci-robot merged commit 03a5fe5 into helm:master Apr 12, 2019
TsuyoshiUshio pushed a commit to TsuyoshiUshio/charts that referenced this pull request Apr 18, 2019
Signed-off-by: James Munnelly <james@munnelly.eu>
hajnej pushed a commit to hajnej/charts that referenced this pull request Apr 24, 2019
Signed-off-by: James Munnelly <james@munnelly.eu>
devnulled pushed a commit to devnulled/charts that referenced this pull request Apr 25, 2019
Signed-off-by: James Munnelly <james@munnelly.eu>
dermorz pushed a commit to dermorz/charts that referenced this pull request Apr 26, 2019
Signed-off-by: James Munnelly <james@munnelly.eu>
goshlanguage pushed a commit to goshlanguage/charts that referenced this pull request May 17, 2019
Signed-off-by: James Munnelly <james@munnelly.eu>
@saplla

saplla commented May 18, 2019

Copy link
Copy Markdown

@munnerz Please can you update the README so the deprecation is obvious. Thanks

eyenx pushed a commit to eyenx/charts that referenced this pull request May 28, 2019
Signed-off-by: James Munnelly <james@munnelly.eu>
@drewwells

Copy link
Copy Markdown
Contributor

Tests here are failing as the chart e2e test cluster doesn't have the cert-manager CRDs installed (this is a recurring problem 🙈)

@prydonius any chance you can re-create these resources so we can get this (final!) PR merged? 😄

Tests should not require hand curating resources on the environment. This is the purpose of handling the lifecycle of chart resources in the chart instead of ad-hoc processes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants