stable/cert-manager: deprecate cert-manager chart - #12970
Conversation
Signed-off-by: James Munnelly <james@munnelly.eu>
d636bad to
ad97c21
Compare
| maintainers: | ||
| - name: munnerz | ||
| email: james@jetstack.io | ||
| # Deprecated charts cannot have maintainers |
There was a problem hiding this comment.
@unguiculus this feels like a weird requirement, but the e2e checker fails if I leave maintainers here 😬
|
According to the Helm chart docs, after this version of the chart is published to the stable repo, we should also remove this chart from the repository altogether. Is that still correct? https://helm.sh/docs/developing_charts/#deprecating-charts When managing charts in a Chart Repository, it is sometimes necessary to deprecate a chart. The optional deprecated field in Chart.yaml can be used to mark a chart as deprecated. If the latest version of a chart in the repository is marked as deprecated, then the chart as a whole is considered to be deprecated. The chart name can later be reused by publishing a newer version that is not marked as deprecated. The workflow for deprecating charts, as followed by the helm/charts project is:
|
|
Tests here are failing as the chart e2e test cluster doesn't have the cert-manager CRDs installed (this is a recurring problem 🙈) @prydonius any chance you can re-create these resources so we can get this (final!) PR merged? 😄 |
|
(... plus a /lgtm and a /retest shortly afterwards, so that this actually makes it in before the cluster gets recycled again 😅) |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: munnerz, unguiculus The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Signed-off-by: James Munnelly <james@munnelly.eu>
Signed-off-by: James Munnelly <james@munnelly.eu>
Signed-off-by: James Munnelly <james@munnelly.eu>
Signed-off-by: James Munnelly <james@munnelly.eu>
Signed-off-by: James Munnelly <james@munnelly.eu>
|
@munnerz Please can you update the README so the deprecation is obvious. Thanks |
Signed-off-by: James Munnelly <james@munnelly.eu>
Tests should not require hand curating resources on the environment. This is the purpose of handling the lifecycle of chart resources in the chart instead of ad-hoc processes. |
What this PR does / why we need it:
Deprecates the cert-manager chart in favour of the new chart hosted by Jetstack on Helm Hub.
Checklist