Skip to content

Conversation

@VisLab
Copy link
Member

@VisLab VisLab commented Jul 5, 2025

No description provided.

@VisLab VisLab requested a review from Copilot July 5, 2025 18:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces the existing Code Climate setup with Qlty, updates CI to generate and upload coverage reports via Qlty, and removes the old Code Climate config.

  • Clarifies a JSDoc parameter in json.js
  • Adds qlty.toml for Qlty configuration
  • Updates GitHub Actions coverage workflow to use Jest and Qlty
  • Removes the legacy .codeclimate.yml

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/bids/types/json.js Refined the @param hedData JSDoc description
qlty.toml Introduced Qlty quality checks configuration
.github/workflows/coverage.yml Switched from Code Climate action to Jest coverage and Qlty upload
.codeclimate.yml Deleted legacy Code Climate configuration
Comments suppressed due to low confidence (3)

src/bids/types/json.js:321

  • Consider specifying generic types in the JSDoc, e.g., @param {Map<string, ParsedHed>} hedData, to improve IDE assistance and type clarity.
   * @param {Map} hedData - A Map with columnValue --> parsed HED string for a sidecar key to check for column splices.

.github/workflows/coverage.yml:23

  • [nitpick] Pin the action to a specific semantic version (e.g., @v1.0.0) rather than a floating major tag to avoid unexpected breaking changes.
        uses: qltysh/qlty-action/coverage@v1

.github/workflows/coverage.yml:25

  • Indent the token and files entries under with: by two additional spaces to align them correctly as child keys of with:.
          token: ${{secrets.QLTY_COVERAGE_TOKEN}}

@VisLab VisLab added dependencies Pull requests that update a dependency file quality Code quality, not must-fix tests Issues related to testcases repo-management Changes to the repository structure unrelated to the end product issues BIDS and HED-specific issue data tasks labels Jul 5, 2025
@VisLab VisLab merged commit b029f34 into hed-standard:main Jul 5, 2025
7 checks passed
@happy5214 happy5214 added this to the 4.1.0 milestone Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file issues BIDS and HED-specific issue data tasks quality Code quality, not must-fix repo-management Changes to the repository structure unrelated to the end product tests Issues related to testcases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants