Skip to content

Conversation

@frenck
Copy link
Member

@frenck frenck commented Nov 8, 2025

Proposed Changes

SSIA

fixes #963

Summary by CodeRabbit

  • Chores
    • Removed codenotary configuration settings from configuration files.

@frenck frenck added the bugfix Inconsistencies or issues which will cause a problem for users or implementors. label Nov 8, 2025
@coderabbitai
Copy link

coderabbitai bot commented Nov 8, 2025

Walkthrough

The SSH add-on's build and config manifests have been updated to remove deprecated codenotary field entries. This addresses supervisor warnings about obsolete metadata configuration fields present in the add-on's manifest.

Changes

Cohort / File(s) Summary
Deprecation cleanup
ssh/build.yaml, ssh/config.yaml
Removed deprecated codenotary configuration entries (base_image and signer settings from build.yaml; codenotary email field from config.yaml)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Straightforward field deletions with no logic impact
  • Both changes are identical in nature (removing the same deprecated configuration block)
  • No behavioral or runtime changes introduced

Poem

🐰 The codenotary block had to go,
Deprecated fields brought warnings low,
With gentle paws, I cleared the way,
The SSH add-on's cleaner today! ✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately summarizes the main change: removing deprecated codenotary fields from configuration files.
Linked Issues check ✅ Passed The PR removes the deprecated codenotary field from ssh/config.yaml and ssh/build.yaml, directly addressing Goal 1 of issue #963.
Out of Scope Changes check ✅ Passed All changes are directly scoped to removing codenotary fields; no unrelated modifications are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch frenck-2025-0438

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dc13d0a and 9f528e8.

📒 Files selected for processing (2)
  • ssh/build.yaml (0 hunks)
  • ssh/config.yaml (0 hunks)
💤 Files with no reviewable changes (2)
  • ssh/build.yaml
  • ssh/config.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: workflows / Build amd64
  • GitHub Check: workflows / Build armv7
  • GitHub Check: workflows / Build aarch64
  • GitHub Check: workflows / Build armv7
  • GitHub Check: workflows / Build amd64
  • GitHub Check: workflows / Build aarch64

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@frenck frenck merged commit 6dbbdf1 into main Nov 8, 2025
22 checks passed
@frenck frenck deleted the frenck-2025-0438 branch November 8, 2025 13:41
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix Inconsistencies or issues which will cause a problem for users or implementors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A warning occurred

2 participants