Some admin (Stack, gitignore)#1247
Closed
mheinzel wants to merge 4 commits intohaskell-servant:masterfrom
Closed
Conversation
09d2db1 to
408de78
Compare
Contributor
Author
|
There seems to be problem with GHCJS in CI: I can try to find some time to see what is going on here, but maybe someone else knows. edit: The same thing seems to be happening on other PRs like #1249. |
`cartesianProduct` was added in universe-base-1.1, which is not in the currently specified nightly-2018-09-28 snapshot.
408de78 to
c40902a
Compare
phadej
reviewed
Dec 15, 2019
| doc/venv | ||
| doc/tutorial/static/api.js | ||
| doc/tutorial/static/jq.js | ||
| tags |
Contributor
There was a problem hiding this comment.
this really should be part of your global gitignore. I'm against putting all editor temporary files into projects .gitignore.
Other stuff looks ok.
Merged
Contributor
|
Cherry-picked parts in #1258. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for some small things I encountered when trying to setup and build the project.
When running
stack build --fast --pedanticI got:This happened because
cartesianProductwas added inuniverse-base-1.1, which is not in the specifiednightly-2018-09-28snapshot.When I tried running
stack ghci servant-http-streams, I noticed it is not part of the stack.yaml (but of the cabal.project).git picked up the
tagsfile created by my editor.Let me know if any of these are not wanted, I'm happy to amend the PR.