Skip to content

Add mysql cookbook example#1198

Merged
alpmestan merged 1 commit intohaskell-servant:masterfrom
jakequade:cookbook-mysql-basic
Aug 7, 2019
Merged

Add mysql cookbook example#1198
alpmestan merged 1 commit intohaskell-servant:masterfrom
jakequade:cookbook-mysql-basic

Conversation

@jakequade
Copy link
Copy Markdown
Contributor

Contributes a basic mysql-backed API with basic CRUD functionalities.

@jakequade
Copy link
Copy Markdown
Contributor Author

cc @arianvp @alpmestan hello again :) as a noob I've spent a while trying to get this to work via variations of the existing cookbook recipes. I thought this would help out first-timers. Keen on thoughts!

@jakequade jakequade force-pushed the cookbook-mysql-basic branch from 7fd4cf2 to 406a0ad Compare July 30, 2019 23:12
Copy link
Copy Markdown
Contributor

@alpmestan alpmestan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this contribution!

I left a few comments, but this looks mostly good to me and I'm certain this will be helpful for servant users. =)

Comment thread doc/cookbook/db-mysql-basics/MysqlBasics.lhs Outdated
Comment thread doc/cookbook/db-mysql-basics/MysqlBasics.lhs Outdated
Comment thread doc/cookbook/db-mysql-basics/MysqlBasics.lhs Outdated
Comment thread doc/cookbook/db-mysql-basics/MysqlBasics.lhs Outdated
@jakequade jakequade force-pushed the cookbook-mysql-basic branch from 406a0ad to 8b73529 Compare August 5, 2019 05:29
Contributes a basic mysql-backed API with basic CRUD functionalities.
@jakequade jakequade force-pushed the cookbook-mysql-basic branch from 8b73529 to 7554ed4 Compare August 5, 2019 05:33
@jakequade
Copy link
Copy Markdown
Contributor Author

Thanks so much for your help @alpmestan - it's been super helpful. I've made those changes, keen on thoughts!

@jakequade
Copy link
Copy Markdown
Contributor Author

Just bumping this one @alpmestan @arianvp - I know you're busy so I wont push any more :) really appreciate all the advice you've given.

@alpmestan alpmestan merged commit e9aec26 into haskell-servant:master Aug 7, 2019
@alpmestan
Copy link
Copy Markdown
Contributor

We'll arrange for this recipe to be CI-checked like the others in a subsequent PR. Ping us if we havent' done so within a month or so.

Thanks a lot for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants