Release 3.0.0 #441
Merged
Release 3.0.0 #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix Sphinx errors/warnings & Misc. cleanups
Separate interface and implementation for periodic sending
Extract cli help automatically
Lots of general tweaks and fixes to the Messages class. * use is_extended_id instead of id_type for message objects * better documentation for Message * run test on CI for logformats_test.py * added channel to docs * add example messages with channel attribute set * change logformat tests * nicer __repr__ * add __slots__, * deprecate id_type * make timestamp comparison a bit more forgiving * use extended_id in constructor * fix TestBlfFileFormat test * implemented Message._check * properly implement warning & update deprecation notes * remove undocumented setting of flags in kvaser backend * add __copy__ and __deepcopy__ * add Message.equals(), and correctly check for equality in failing tests * Remove message hash implementation * small tweak to codecov
* Bump version to 3.0.0-dev and update deprecation notes * Update changelog with message changes * Split installation requirements onto own line
# Conflicts: # CHANGELOG.txt # can/__init__.py # can/interface.py # can/interfaces/vector/canlib.py
* Start migration of Message init to use is_extended_id * Update deprecation versions in message.py #424
Codecov Report
@@ Coverage Diff @@
## master #441 +/- ##
========================================
Coverage ? 62.5%
========================================
Files ? 55
Lines ? 4659
Branches ? 0
========================================
Hits ? 2912
Misses ? 1747
Partials ? 0 |
Collaborator
|
Please include #446 in this release. |
Add last minute changes release
Owner
Author
Now just waiting for an approving review and we can release. Latest release candidate includes this too: |
Collaborator
|
Thank you @hardbyte. |
christiansandberg
approved these changes
Oct 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assuming we've solved the installation issue (#431 (comment)) this PR makes up the 3.0.0 release.
For the most part issues and pull requests were in this milestone: https://github.com/hardbyte/python-can/milestone/4?closed=1
Get the latest release candidate with:
Note: I closed the pull request #438 that was trying to directly merge develop into master. With this
release-branchapproach we can keep merging features into develop that won't effect the 3.0 release.With regard to review, I think we just need to sanity check that everything works, and that we've not left anything out of the docs, changelogs or acknowledgements.