Adding multiple channels support to neoVI #415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixdivo
requested changes
Sep 15, 2018
| :param int channel: | ||
| The Channel id or name to create this bus with. | ||
| :param list channel: |
Collaborator
There was a problem hiding this comment.
Well, we should annotate this with the correct type. See "Container types such as lists and dictionaries can be linked automatically using the following syntax: ...".
| ics_msg.StatusBitField3 & ics.SPY_STATUS3_CANFD_BRS | ||
| ), | ||
| channel=ics_msg.NetworkID | ||
| channel=int(ics_msg.NetworkID) |
Collaborator
There was a problem hiding this comment.
Isn't this already an int? If not, wouldn't line 221 fail?
| if msg.channel is not None: | ||
| message.NetworkID = msg.channel | ||
| else: | ||
| # defaults to the first channel in channels |
Collaborator
There was a problem hiding this comment.
This could be surprising! We should at least document this clearly, or maybe even raise an Exception? Another option would be to send it to all, but I guess that is unexpected as well?
Codecov Report
@@ Coverage Diff @@
## develop #415 +/- ##
===========================================
- Coverage 61.65% 61.51% -0.14%
===========================================
Files 55 55
Lines 4572 4584 +12
===========================================
+ Hits 2819 2820 +1
- Misses 1753 1764 +11 |
felixdivo
approved these changes
Sep 23, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.