[codex] Omit default config fields when persisting jobs and trials#2175
Merged
Conversation
Contributor
|
Enjoy a better diff viewing experience by clicking one of these URLs: |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Persist job and trial
config.jsonfiles withexclude_defaults=Trueso generated runtime configs omit values that match model defaults.Why
Runtime config files were including default empty values even though config init paths already serialize more compactly. The persisted job and trial configs should record the meaningful user-provided configuration while leaving defaults implicit.
Impact
This keeps normal Pydantic model serialization unchanged and only affects the write paths for job and trial config artifacts.
Validation
uv run ruff check --fix .uv run ruff format .uv run ty checkuv run pytest tests/unit/