fix(rewardkit): retry agent judge CLI exits#2148
Merged
Merged
Conversation
A non-zero agent CLI exit raised immediately, bypassing the retry loop that already handles malformed judge JSON, so a transient claude exit (e.g. error_max_structured_output_retries) aborted the verifier before reward.json was written. Retry CLI exits like parse failures and raise only after the retry budget is exhausted. Fixes #2114.
Contributor
|
Enjoy a better diff viewing experience by clicking one of these URLs: |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
alexgshaw
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agent judge CLI exits now retry within the existing judge retry loop instead of aborting on the first failure (fixes #2114).
_arun_agent_callraised immediately on a non-zero CLI exit, sitting inside the retry loop but outside thetry/exceptthat retries malformed judge JSON, so the failure bypassed_MAX_JUDGE_RETRIES.error_max_structured_output_retries(exit 1); the verifier then exited before writingreward.jsonand Harbor reportedRewardFileNotFoundError.