Skip to content

Write trial locks and remove invocation from job locks#2138

Merged
alexgshaw merged 2 commits into
mainfrom
codex/update-job-and-trial-locks
Jun 30, 2026
Merged

Write trial locks and remove invocation from job locks#2138
alexgshaw merged 2 commits into
mainfrom
codex/update-job-and-trial-locks

Conversation

@alexgshaw

@alexgshaw alexgshaw commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add lock.json output for trials so resolved inputs are captured alongside each trial run.
  • Bump job lock schema to v2 and make resume tolerant of older lock files by comparing against the current schema version.
  • Remove CLI invocation from job locks and keep task digests available from downloaded task metadata when possible.

Testing

  • Added unit coverage for trial lock writing and updated job lock/resume expectations.
  • Existing unit tests updated to validate the new lock schema and omitted invocation field.

Open in Devin Review

@vercel

vercel Bot commented Jun 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
harbor-docs Ready Ready Preview, Comment Jun 30, 2026 5:47am

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

Enjoy a better diff viewing experience by clicking one of these URLs:

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

Open in Devin Review

Comment thread src/harbor/models/job/lock.py
@alexgshaw alexgshaw merged commit b08e765 into main Jun 30, 2026
9 checks passed
@alexgshaw alexgshaw deleted the codex/update-job-and-trial-locks branch June 30, 2026 06:22
Messimeimei added a commit to Messimeimei/bitfun-harbor that referenced this pull request Jul 7, 2026
…k format evolution. (harbor-framework#2149)

b276e04 feat: add implementation for ack environmeent (harbor-framework#1424)
64e8217 Update publish.sh
6e46b7c Fix configs
2fa55c3 fix(langgraph): build agent venv with a uv-managed Python (harbor-framework#2130)
89359f5 Align trial hook event identity fields (harbor-framework#2134)
7819c48 feat(opensandbox): add OpenSandbox environment support (harbor-framework#2054)
2ea6152 docs: improve citability with Zenodo concept DOI (harbor-framework#2135)
b08e765 Write trial locks and remove invocation from job locks (harbor-framework#2138)
aaf0561 Align log entry trial identity (harbor-framework#2137)
5a5681c feat(langsmith): nest custom BaseAgent traces under the trial run (harbor-framework#2129)
f456c6f [Ready for Review] Adapter: OsWorld (harbor-framework#1836)
ae95837 add viewer recording tab (harbor-framework#2117)
25165b9 [codex] Upload trial locks and use lock task hash (harbor-framework#2140)
0567de7 Add a new error type.
f7f2498 Add schema_version to TrialLock for lock format evolution. (harbor-framework#2149)

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant