Skip to content

fix(job): disable Rich stdout/stderr redirect to avoid deadlocks#1829

Merged
alexgshaw merged 1 commit into
mainfrom
cursor/e7015747
Jun 5, 2026
Merged

fix(job): disable Rich stdout/stderr redirect to avoid deadlocks#1829
alexgshaw merged 1 commit into
mainfrom
cursor/e7015747

Conversation

@alexgshaw

@alexgshaw alexgshaw commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Disable redirect_stdout and redirect_stderr on job Progress bars and the wrapping Live display.
  • Prevents third-party stdout/stderr (e.g. aiohttp finalizer logging, LiteLLM prints) from being routed through Rich's live renderer, which can deadlock under high concurrency.

Related upstream issue: Textualize/rich#4158

Test plan

  • Verified harbor run progress UI still renders in quiet and non-quiet modes
  • Run a concurrent benchmark job and confirm the process no longer freezes on Rich lock inversion

Third-party output routed through Live's redirected streams can invert
Console and Live locks during long benchmark runs.

Co-authored-by: Cursor <cursoragent@cursor.com>
@vercel

vercel Bot commented Jun 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
harbor-docs Ready Ready Preview, Comment Jun 5, 2026 6:00pm

Request Review

@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Enjoy a better diff viewing experience by clicking one of these URLs:

@alexgshaw alexgshaw marked this pull request as ready for review June 5, 2026 18:01

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@alexgshaw alexgshaw merged commit 6cd496d into main Jun 5, 2026
10 checks passed
@alexgshaw alexgshaw deleted the cursor/e7015747 branch June 5, 2026 19:32
Messimeimei added a commit to Messimeimei/bitfun-harbor that referenced this pull request Jul 7, 2026
700972a fix(gemini_cli): pre-select auth method for headless API-key/Vertex runs (harbor-framework#1794)
590f4f7 Fix installed agent ATIF exports (harbor-framework#1812)
9f65643 Update Islo SDK integration (harbor-framework#1824)
6cd496d fix(job): disable Rich stdout/stderr redirect to avoid deadlocks (harbor-framework#1829)
66cffed Suppress litellm debug output unless --debug is enabled (harbor-framework#1828)
48a577a Open PR diff links in a new tab. (harbor-framework#1831)
ae938b8 feat: GKE multi-container support via privileged DinD compose (harbor-framework#1773)
e1066b5 Add use.computer environment (harbor-framework#1834)
0f08f40 fix(pi): Reduce logging footprint (harbor-framework#1826)
9801da1 Update mini_swe_agent.py (harbor-framework#1837)
918a791 fix(check): accept all Claude auth methods, preferring the free subscription (harbor-framework#1766)
13f9692 fix(env): tar-based directory transfers for Modal, Daytona, and GKE (harbor-framework#1838)
8cfac6a Add Docker Compose support to Novita (harbor-framework#1830)
c978013 harbor-langsmith: persist run tags (top-level) and dataset metadata (under extra) (harbor-framework#1808)
a56546f Support wildcard network allowlist hosts (harbor-framework#1840)
6cd263a feat: add LangSmith sandbox environment (harbor-framework#1610)
e75ecc0 rewardkit: add REWARDKIT_MODEL override for agent judges (harbor-framework#1778)
9c78b85 Update Claude Code bootstrap installer URL (harbor-framework#1852)
6a21701 Added cline v2 and ATIF Trajectory support (harbor-framework#1495)
6996f65 feat(claude_code): support CLAUDE_FORCE_OAUTH to bill the subscription on harbor run (harbor-framework#1846)
904b323 Add built-in LangGraph agent (harbor-framework#1807)
b8976c9 Add GPU support to the Daytona environment (harbor-framework#1731)
2922220 Preserve tagged Docker images on delete (harbor-framework#1861)
c2c5796 Improve use.computer environment (harbor-framework#1853)
3de07a0 add session-id header (harbor-framework#1855)
3f941bd ci: fix ai-review fork-PR checkout for claude-code-action@v1 (harbor-framework#1874)
cdee965 Add network policy docs page under Tasks
253c546 Document environment support for network modes, phases, and capabilities
8d3384a Add Novita network policy support (harbor-framework#1867)
5270111 add procps to prevent process crashes when claude-code call tree-kill (harbor-framework#1864)
4195631 Add generic ACP registry agent support (harbor-framework#1464)
96eaf6b v0.13.2

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant