Use AArch64 assembly syntax on macOS with LLVM<22 #8710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abadams
approved these changes
Aug 5, 2025
Member
Author
|
Failures are unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion on llvm/llvm-project#151330, it was determined that the reason SDOT arguments were missing in the assembly output was that the AArch64InstrFormats table was missing some entries for the Apple/Darwin-specific format.
This PR uses the AArch64 format on older LLVM versions that won't receive the upstream patch.
This fix was derived by reading the upstream patch that fixes this issue: llvm/llvm-project#152111
ATTN @rtzam
Fixes #8697