Use pmaddubsw for non-RDom horizontal widening adds #7440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootjalex
reviewed
Mar 21, 2023
Comment on lines
+786
to
+790
| // Rewrite combinations of deinterleaves into horizontal ops | ||
| rewrite(widening_add(slice(x, 0, 2, lanes), slice(x, 1, 2, lanes)), | ||
| h_add(cast(op->type.with_lanes(lanes * 2), x), lanes)) || | ||
| rewrite(widening_add(slice(x, 1, 2, lanes), slice(x, 0, 2, lanes)), | ||
| h_add(cast(op->type.with_lanes(lanes * 2), x), lanes)) || |
Member
There was a problem hiding this comment.
I think it might be useful to have a mutator that attempts to perform this operation more generally, for other operations as well?
rootjalex
approved these changes
Mar 21, 2023
Member
rootjalex
left a comment
There was a problem hiding this comment.
LGTM, left a small comment about a future possible codegen improvement but it's not necessary for this PR imo
ardier
pushed a commit
to ardier/Halide-mutation
that referenced
this pull request
Mar 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were rewriting the following into a pmaddubsw:
But not the equivalent unrolled version, which is more likely to be written:
This pattern shows up in downsampling code.
This PR fixes it, and also adds support for doing horizontal widening adds of i16 to i32 using pmaddwd, and adds some missing avx512 variants of horizontal adds using pmaddubsw.