Repository navigation
security: retain Vitest fixes after Stripe upgrade landed - #2402
Open
dependabot[bot] wants to merge 5 commits into
Open
dependabot[bot] wants to merge 5 commits into
dependabot[bot] wants to merge 5 commits into
Conversation
Bumps [stripe](https://github.com/stripe/stripe-node) from 22.6.2 to 23.0.0. - [Release notes](https://github.com/stripe/stripe-node/releases) - [Changelog](https://github.com/stripe/stripe-node/blob/master/CHANGELOG.md) - [Commits](stripe/stripe-node@v22.6.2...v23.0.0) --- updated-dependencies: - dependency-name: stripe dependency-version: 23.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the
 |
Contributor
✅ E2E Test Results: ALL TESTS PASSED
Test Output |
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files
|
groupthinking
requested changes
Oct 28, 2026
groupthinking
left a comment
Owner
There was a problem hiding this comment.
Review at head da363e20: this PR changes apps/web/package.json without updating the root package-lock.json, and current-head build, lint, and frontend test checks fail. Reconcile the workspace lockfile with the manifest, then rerun the checks before approval.
Contributor
✅ E2E Test Results: ALL TESTS PASSED
Test Output |
groupthinking
previously approved these changes
Oct 28, 2026
groupthinking
left a comment
Owner
There was a problem hiding this comment.
Code review at 0fc40561efc4d581ed91b03690c94432f3df064e: the earlier requested manifest/lockfile reconciliation is complete, and the current hosted build, lint, frontend tests, and issue-link checks pass. The two-file diff upgrades server-side Stripe to 23.0.1; clean install, web tests (1,520 passed, 28 skipped), lint, type check, and production build passed locally. Stripe 23 changes its default API version to 2026-09-30.endive; I checked the app's Checkout Session and webhook call sites against Stripe's v23 migration guide. The app does not pass the removed payment_method_types parameter or use the listed V2/error helper APIs, and its declared Node floor satisfies v23's Node 20 minimum.
I approve the code change at this head. This is not a merge recommendation or a verified payment outcome. A real Stripe test-mode checkout, webhook, and entitlement roundtrip has not been run because this workspace has no test-mode key or configured test prices. The shared dependency-review evidence job also fails. Keep the PR open until those gates are checked.
Contributor
✅ E2E Test Results: ALL TESTS PASSED
Test Output |
Contributor
Author
|
A newer version of stripe exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
This was referenced Nov 4, 2026
Contributor
✅ E2E Test Results: ALL TESTS PASSED
Test Output |
Contributor
🔍 PR Validation |
groupthinking
approved these changes
Nov 10, 2026
groupthinking
left a comment
Owner
There was a problem hiding this comment.
Reviewed current head 835cbe73385b2e32cc3be39fe0641cb9e5f1e216 against main 61522e9170a91bf8c8c6bf02f2e5dbdf2eb5bbd6.
The final diff changes only nine complete root development lock records: Vitest and seven companion packages 4.1.11 → 4.1.12, plus tinyrainbow 3.1.1 → 3.2.0. Current Stripe 23.1.0, both manifests, billing, authorization and feature flags remain identical to main. The tested GitHub merge tree equals the reviewed source tree.
Verified clean npm10.8 install, 1,546 local web tests (28 skipped), two existing offline root-Vitest consumer tests, types, lint and 47-page build. Hosted checks pass, including 1,573 web tests (1 skipped), Docker/build, 21 real-service preflight checks and 16 preview tests. Dependency artifact 13770592899 matches all 18 typed live comparison records and the full lock delta. No unresolved review threads.
The root Vitest updates remove the two affected 4.x advisory entries. Full audit remains 25 high / 22 moderate, with no new advisory IDs; the separate web Vitest5.0.1 and other existing baseline findings remain. Approval covers this bounded lockfile repair; it does not establish repository-wide security cleanliness or a new live billing roundtrip.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current change
Current head
835cbe73385b2e32cc3be39fe0641cb9e5f1e216integratesmainat61522e9170a91bf8c8c6bf02f2e5dbdf2eb5bbd6. Main already uses server-side Stripe 23.1.0. That accepted version, both manifests, and all application code are retained unchanged.The remaining diff is only
package-lock.json: root Vitest and its seven companion packages move 4.1.11 → 4.1.12, and transitivetinyrainbowmoves 3.1.1 → 3.2.0. These nine complete development-dependency records were present in this PR and would have been lost by simply closing the old Stripe update. Direct/transitive classification, integrity metadata, current billing behavior and feature flags are preserved.Validation
npm ci --ignore-scriptsinstalled 1,008 packages; the inspected Workflow postinstall patch ran successfully.npm --workspace=apps/web test: 1,546 passed, 28 skipped using the web workspace's separate Vitest 5.0.1. The updated root Vitest 4.1.12 also passed the two existing offlineE2E request attributiontests; live fetch was prohibited for that local check.npm --workspace=apps/web run type-check,npm --workspace=apps/web run lint,npm run build:web, andgit diff --checkpassed; the build generated 47 pages.Security dependency evidence
@vitest/mocker>=2.1.0-beta.7,<4.1.12 in the 4.x line; GHSA-xp26-3454-mjgp affects >=4.1.11,<4.1.12. Both are fixed in 4.1.12 (5.x is fixed separately in 5.0.3). Official records retrieved November 10, 2026.vitest4.1.11 → 4.1.12, with transitive@vitest/mockerand six companion packages 4.1.11 → 4.1.12; transitivetinyrainbow3.1.1 → 3.2.0. Dependency path: rootvitest→@vitest/mocker.npm audit --jsonremains nonzero: 0 critical, 25 high, 22 moderate, matching main's package-level counts. The two affected root 4.x advisory entries are removed, no advisory IDs are added, and the separate web Vitest 5.0.1 plus other baseline findings remain. This is not a clean repository-wide audit or a policy waiver.The original Stripe major-version notes below are historical. This candidate changes neither the accepted Stripe 23.1.0 installation nor the billing implementation; no new test-mode checkout/subscription/signed-webhook roundtrip is claimed. This PR remains open and unmerged.
Original Dependabot notes
Bumps stripe from 22.6.2 to 23.0.0.
Release notes
Sourced from stripe's releases.
... (truncated)
Changelog
Sourced from stripe's changelog.
... (truncated)
Commits
fe645f6Bump version to 23.0.014d17e2Correct v23 migration guidance links (#2880)bc1bbb4Merge pull request #2879 from stripe/latest-codegen-master1aaf232Update generated code for v2526 and 588801ef34f7b5f7d6a784d3354f5f93d2a26ffb63be8e6Update generated code (#2832)d1a1df1Pin stripe-mock to the SDK OpenAPI version (#2870)e280a13Merge pull request #2857 from stripe/sdk-release/next-majoreb8f079Drop Node's uuid4 override in node platform functions (#2861)4956bcfUpdate verifyHeader and verifyHeaderAsync methods to use DEFAULT_TOLERANCE (#...42f051aClassify incomplete response bodies as connection errors (#2868)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)