Modified configuration in lf_base_interop_profile.py , py-json/interop_connectivity.py and Added robo in Port reset test #219
Conversation
…hanges according to 5.5.2 build. Signed-off-by: Sidartha-CT <[email protected]>
Signed-off-by: Sidartha-CT <[email protected]>
…elper. Signed-off-by: Sidartha-CT <[email protected]>
…_report. -For the purpose of robo heatmap ,moved dewebgui code to above the generate_report. Signed-off-by: Sidartha-CT <[email protected]>
memnochproxy
left a comment
There was a problem hiding this comment.
I would prefer you do this with f-strings, eg:
f'--es ssid "{cur_ssid}" '
Is there a reason you are using \" inside a single quote? Do the backslashes fix something that resulting command?
memnochproxy
left a comment
There was a problem hiding this comment.
Please do not mix multiple string formatting methods. You have some " %s "%foo strings in there. Let's standardise on f-strings, please. You also have some "{}".format() calls, change those to f-strings too.
memnochproxy
left a comment
There was a problem hiding this comment.
Please address inline structural comments.
I think the lines in this file are getting rather long, too.
PEP8 requires line length of 79 chars.
…test Verified CLI : python3 lf_interop_port_reset_test.py --host 192.168.207.78 --mgr_ip eth1 --dut AP --ssid "NETGEAR_2G_wpa2" --encryp psk2 --passwd Password@123 --reset 2 --time_int 5 --robot_test --coordinate 4,3 --robot_ip 192.168.200.169 --device_list ubuntu24 Signed-off-by: Sidartha-CT <[email protected]>
Hi Jed (@memnochproxy ) , To maintain consistency, we have implemented the same handling in our scripts that include Android configurations. Please let me know if you have any concerns or if further changes are required. |
Yes, Jed (@memnochproxy ). The inline comments were added by previous developers during the initial development of this script. To add robot-specific logic for the port reset with bit priority, I moved that block into a separate helper so it can be reused. That said, we will clean up the inline structural comments and ensure the file adheres to PEP8 standards, including the 79-character line length, in the future commits. |
6863627 to
9f4c7ec
Compare
|
I appreciate your willingness to correct and improve previous coders work. It may feel like busywork, however the effort really helps everyone 💯 |
No description provided.