Zoom Test with Device Groups and SSID profile support #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Narayana-CT <narayana.pinapatruni@candelatech.com>
- Remove commented-out/redundant path definitions in __init__. - Add self.config_obj attribute. - Ensure device list is refreshed via real_device_obj.get_devices() before station selection. - Remove redundant test parameter DataFrame assignment. Signed-off-by: Narayana-CT <narayana.pinapatruni@candelatech.com>
…dio/video test result handling - Refactored audio and video test result table generation to use unified dict structures. - Introduced group-specific test report creation for selected groups and profiles. - Added get_test_results_data() helper to filter test results per group. - Updated main() to: - Pass wait_time to DeviceConfig initialization. - Assign config_obj to zoom_automation instance. - Modify connectivity logic to handle short device list format (conn_dev_list). Signed-off-by: Narayana-CT <narayana.pinapatruni@candelatech.com>
- Deleted obsolete webUI status update block in main() that posted test completion status to /update_status_yt endpoint. Signed-off-by: Narayana-CT <narayana.pinapatruni@candelatech.com>
Signed-off-by: Narayana-CT <narayana.pinapatruni@candelatech.com>
a-gavin
reviewed
Nov 13, 2025
a-gavin
reviewed
Nov 13, 2025
a-gavin
requested changes
Nov 13, 2025
Collaborator
a-gavin
left a comment
There was a problem hiding this comment.
Minor changes requested.
…ndling, and report generation - Added dedicated start_client_cx() method to start client-side connections individually. - Replaced self.generic_endps_profile.start_cx() with self.start_client_cx() for better control of connection startup. - Implemented file existence check before reading CSVs; missing files are now skipped with a warning log. - Fixed logging error format when reading client data fails. - Updated audio and video report generation to append HTML content (+=) instead of overwriting, ensuring all group tables display correctly. - Added ssid argument to ZoomAutomation initialization for extended configuration handling. - Modified device list logic to adjust ordering and ensure zoom_host is always first in non-webUI runs. - Improved code readability and maintainability in main() and report generation sections. Verified CLI: python3 lf_interop_zoom.py --duration 1 --lanforge_ip 192.168.214.219 --signin_email demo@gmail.com --signin_passwd Demo@123 --participants 3 --audio --video --resources 1.400,1.375 --zoom_host 1.95 --upstream_port 1.1.eth1 Signed-off-by: Narayana-CT <narayana.pinapatruni@candelatech.com>
9d841e4 to
88e44f4
Compare
Contributor
Author
|
Hi Alex, as suggested added comments to the code part mentioned. Thank you |
a-gavin
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added start_client_cx() for controlled client connection startup.
Implemented file existence check and improved error logging.
Refactored audio/video report generation to support multiple groups and append all results correctly.
Removed obsolete and commented-out code.
Resolved linting and formatting issues to achieve cleaner code.