Skip to content

Export ESM#19

Merged
grandchild merged 61 commits intodevelopfrom
feature/esm
Sep 10, 2021
Merged

Export ESM#19
grandchild merged 61 commits intodevelopfrom
feature/esm

Conversation

@idleberg
Copy link
Collaborator

This PR introduces several major changes, that interdepend on each other:

  • exports CommonJS and ESM
  • bundle with Rollup
  • remove all uses of eval()
  • add a large number of tests
  • remove utils test (temporarily?)

Copy link
Owner

@grandchild grandchild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick read-through, I'll run the code later today or tomorrow.

Copy link
Owner

@grandchild grandchild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last small thing.

@grandchild
Copy link
Owner

1376 tests passed

that is pretty cool! 😎

so, yeah, just the one last rename, then i'll merge right away.

@grandchild grandchild merged commit bf9fb05 into develop Sep 10, 2021
@grandchild grandchild deleted the feature/esm branch September 10, 2021 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants