Skip to content
This repository was archived by the owner on May 14, 2026. It is now read-only.

feat(gax): append cred-type header for auth metrics #3186

Merged
zhumin8 merged 14 commits into from
Oct 4, 2024
Merged

feat(gax): append cred-type header for auth metrics #3186

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
2dbd2d8
feat: expose credential type as part of x-goog-api-client header.
zhumin8 Sep 3, 2024
ee2624c
test: add test correctly appends cred-type to header.
zhumin8 Sep 10, 2024
fe3ed54
use enum for credential types.
zhumin8 Sep 13, 2024
0cd0ad8
update type.
zhumin8 Oct 1, 2024
b1dd5b0
fix naming and comment.
zhumin8 Oct 2, 2024
781f161
Merge branch 'main' into auth-metrics
zhumin8 Oct 2, 2024
01adbde
Merge branch 'main' into auth-metrics
zhumin8 Oct 3, 2024
32f8934
fix credential is null case.
zhumin8 Oct 3, 2024
51bed23
add test case.
zhumin8 Oct 3, 2024
0424fd2
update test, extract test setup steps.
zhumin8 Oct 3, 2024
0e69f72
Merge branch 'main' into auth-metrics
zhumin8 Oct 4, 2024
b50896a
address feedback: encapsulate credentials metrics logic inside getHea…
zhumin8 Oct 4, 2024
6e60633
address feedback.
zhumin8 Oct 4, 2024
33e24d9
update comment.
zhumin8 Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
address feedback.
  • Loading branch information
@zhumin8
zhumin8 committed Oct 4, 2024
commit 6e60633f4c9faa5176afbad0750e1115bbe63e6d
5 changes: 5 additions & 0 deletions gax-java/gax/src/main/java/com/google/api/gax/rpc/ClientContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,6 +348,11 @@ private static Map<String, String> getHeaders(StubSettings settings, Credentials
effectiveHeaders.putAll(userHeaders);
effectiveHeaders.putAll(conflictResolution);

return appendCredentialTypeToHeaderIfPresent(effectiveHeaders, credentials);
}

private static Map<String, String> appendCredentialTypeToHeaderIfPresent(
Map<String, String> effectiveHeaders, Credentials credentials) {
CredentialTypeForMetrics credentialTypeForMetrics =

@blakeli0 blakeli0 Oct 4, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: extract this to a private method for better readability.

credentials == null
? CredentialTypeForMetrics.DO_NOT_SEND
Expand Down