Skip to content

chore: Fix flaky testCancelIsTraced test #2039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lqiu96 merged 7 commits into from
Oct 26, 2023
Merged

chore: Fix flaky testCancelIsTraced test #2039

lqiu96 merged 7 commits into from
Oct 26, 2023

Conversation

@lqiu96
Copy link
Member

@lqiu96 lqiu96 commented Sep 26, 2023

Thank you for opening a Pull Request! For general contributing guidelines, please refer to contributing guide

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1941 ☕️

Similar to #2006

@lqiu96 lqiu96 requested review from a team and blakeli0 September 26, 2023 21:19
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Sep 26, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 26, 2023

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lqiu96
Copy link
Member Author

lqiu96 commented Oct 13, 2023

On second thought, perhaps it is better to remove the testCancelIsTraced as it is very similar to the testCancelOuterFutureAfterStart test above. We can use the testCancelOuterFutureAfterStart test to check that the trace has been cancelled.

blakeli0
blakeli0 approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@blakeli0 blakeli0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. Please resolve the comments before merging.

lqiu96 and others added 2 commits October 26, 2023 17:46
@lqiu96 @blakeli0
Update gax-java/gax/src/test/java/com/google/api/gax/retrying/Schedul…
a796863 
…edRetryingExecutorTest.java

Co-authored-by: Blake Li <blakeli@google.com>
@lqiu96
chore: Remove unneeded comment
8c244f7
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 26, 2023

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 26, 2023

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lqiu96 lqiu96 merged commit 5654aa6 into main Oct 26, 2023
@lqiu96 lqiu96 deleted the fix-testCancelIsTraced branch October 26, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blakeli0 blakeli0 blakeli0 approved these changes

Assignees

No one assigned

Labels

size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

gax-java(mac): Flaky ScheduledRetryingExecutorTest.testCancelIsTraced

2 participants

@lqiu96 @blakeli0