Skip to content

tests: add retry conformance test cases and markdown #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cojenco merged 8 commits into from
Sep 21, 2021
Merged

tests: add retry conformance test cases and markdown #594

cojenco merged 8 commits into from
Sep 21, 2021

Conversation

@cojenco
Copy link
Contributor

@cojenco cojenco commented Sep 20, 2021

  • Add scenario 5 to test schema: Libraries never retry non-retryable errors for any operations
  • Add scenario 6 to test schema: Libraries behave correctly with a mix of retryable and non-retryable errors
  • Add markdown file
  • Clean up and align json file to match with test schema in conformance-tests

@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Sep 20, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 20, 2021
@cojenco cojenco marked this pull request as ready for review September 20, 2021 23:19
@cojenco cojenco requested review from a team as code owners September 20, 2021 23:19
unforced
unforced approved these changes Sep 21, 2021
View reviewed changes
Copy link
Contributor

@unforced unforced left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cojenco cojenco merged commit 72f22b0 into googleapis:main Sep 21, 2021
@danielduhh
Copy link
Contributor

danielduhh commented Sep 23, 2021

Late review but if you rename the file to README.md, it'll render when you open the directory. @cojenco

cojenco added a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@cojenco
tests: add retry conformance test cases and markdown (googleapis#594)
359d9a0 
* add scenario 5 to test schema

* align json with conformance test repo

* add scenario 6 to test schema

* sort import statements

* add md file for retry conf tests

* revise markdown
cojenco added a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@cojenco
tests: add retry conformance test cases and markdown (googleapis#594)
6974fb8 
* add scenario 5 to test schema

* align json with conformance test repo

* add scenario 6 to test schema

* sort import statements

* add md file for retry conf tests

* revise markdown
@cojenco cojenco deleted the conftests5-16 branch December 3, 2021 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@unforced unforced unforced approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the googleapis/python-storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cojenco @danielduhh @unforced