Skip to content

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Nov 11, 2020

See also: #283

This PR adds explicit coverage for each member of google.cloud.storage.retry. Together with PR #284, should return this package to 100% unit test coverage.

@tseaver tseaver requested review from andrewsg and crwilcox November 11, 2020 21:10
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Nov 11, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 11, 2020
@tseaver tseaver changed the title tests: explicit coverage for retry tests: add explicit coverage for retry members Nov 11, 2020
@tseaver
Copy link
Contributor Author

tseaver commented Nov 11, 2020

Flaky unit test reported in #309

@tseaver
Copy link
Contributor Author

tseaver commented Nov 11, 2020

Blocked on PR #310.

@tseaver
Copy link
Contributor Author

tseaver commented Nov 12, 2020

Rebuilding after merge of #310 (to fix flaky unit test).

@tseaver tseaver requested review from frankyn and tswast November 13, 2020 22:42
@tseaver tseaver added the automerge Merge the pull request once unit tests and other checks pass. label Nov 16, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit ed006ca into master Nov 16, 2020
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 16, 2020
@tseaver tseaver deleted the tests-coverage-for-retry branch August 24, 2021 18:07
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
See also: googleapis#283 

This PR adds explicit coverage for each member of `google.cloud.storage.retry`.  Together with PR googleapis#284, should return this package to 100% unit test coverage.
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
See also: googleapis#283 

This PR adds explicit coverage for each member of `google.cloud.storage.retry`.  Together with PR googleapis#284, should return this package to 100% unit test coverage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/python-storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants