docs: deprecate google.cloud.firestore_v1.rate_limiter.utcnow#716
Merged
docs: deprecate google.cloud.firestore_v1.rate_limiter.utcnow#716
Conversation
These will be deprecated starting in Python 3.12. Replaced: - `datetime.datetime.utcnow()` with `datetime.datetime.now(tz=datetime.timezone.utc)` - `datetime.utcfromtimestamp()` with `datetime.fromtimestamp(tz=datetime.timezone.utc)`
pganssle
approved these changes
May 11, 2023
pganssle
left a comment
There was a problem hiding this comment.
Looks good from what I can tell, except for the change to the public interface, which you'd know more about than me.
Contributor
|
Added |
parthea
reviewed
Nov 30, 2023
Contributor
|
I filed #812 for the issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These will be deprecated starting in Python 3.12.
Replaced:
datetime.datetime.utcnow()withdatetime.datetime.now(tz=datetime.timezone.utc)datetime.utcfromtimestamp()withdatetime.fromtimestamp(tz=datetime.timezone.utc)Source: python/cpython#103857
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕
BEGIN_COMMIT_OVERRIDE
fix: Remove used of deprecated
datetime.datetime.utcnow()anddatetime.utcfromtimestamp()docs: deprecate google.cloud.firestore_v1.rate_limiter.utcnow
END_COMMIT_OVERRIDE