Skip to content

Comments

test: Mark document snapshot hash as flaky#699

Merged
Mariatta merged 2 commits intomainfrom
tests-flaky-snapshot-hash
Mar 23, 2023
Merged

test: Mark document snapshot hash as flaky#699
Mariatta merged 2 commits intomainfrom
tests-flaky-snapshot-hash

Conversation

@Mariatta
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #510 🦕

@Mariatta Mariatta requested review from a team as code owners March 21, 2023 00:52
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: firestore Issues related to the googleapis/python-firestore API. labels Mar 21, 2023
use the pytest.mark.xfail decorator
@Mariatta Mariatta force-pushed the tests-flaky-snapshot-hash branch from 76ab3de to 647f1d0 Compare March 21, 2023 01:02
Copy link

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mariatta Mariatta merged commit 9e4a018 into main Mar 23, 2023
@Mariatta Mariatta deleted the tests-flaky-snapshot-hash branch March 23, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: firestore Issues related to the googleapis/python-firestore API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tests.unit.v1.test_base_document: test_documentsnapshot___hash__ failed

3 participants