Skip to content

Comments

test: Remove tests wrt foreign key#631

Merged
parthea merged 1 commit intomainfrom
fix-foreign-key-test
Aug 26, 2022
Merged

test: Remove tests wrt foreign key#631
parthea merged 1 commit intomainfrom
fix-foreign-key-test

Conversation

@Mariatta
Copy link
Contributor

@Mariatta Mariatta commented Aug 25, 2022

There is no restriction about this in the backend.
Removing the tests since they're not needed.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #610 🦕
Fixes #611 🦕

Closes internal issue #137866686

There is no restriction about this in the backend.
Removing the tests since they're not needed.
@Mariatta Mariatta requested review from a team as code owners August 25, 2022 18:35
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: firestore Issues related to the googleapis/python-firestore API. labels Aug 25, 2022
@parthea parthea merged commit db0ab16 into main Aug 26, 2022
@parthea parthea deleted the fix-foreign-key-test branch August 26, 2022 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: firestore Issues related to the googleapis/python-firestore API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tests.system.test_system_async: test_cannot_use_foreign_key failed tests.system.test_system: test_cannot_use_foreign_key failed

2 participants