Skip to content

Comments

fix(firestore): fix lint#48

Merged
crwilcox merged 1 commit intogoogleapis:masterfrom
MaxxleLLC:firestore_issue_47
May 18, 2020
Merged

fix(firestore): fix lint#48
crwilcox merged 1 commit intogoogleapis:masterfrom
MaxxleLLC:firestore_issue_47

Conversation

@HemangChothani
Copy link
Contributor

Fixes #47

This PR fixes a lint error that recently started occurring on master out of the blue.

How to verify

Run the lint check on master:

$ nox -f noxfile.py -s lint

@HemangChothani HemangChothani requested a review from crwilcox May 14, 2020 14:46
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 14, 2020
@crwilcox crwilcox merged commit 7fa00c4 into googleapis:master May 18, 2020
gcf-merge-on-green bot pushed a commit that referenced this pull request May 18, 2020
🤖 I have created a release \*beep\* \*boop\* 
---
## [1.7.0](https://www.github.com/googleapis/python-firestore/compare/v1.6.2...v1.7.0) (2020-05-18)


### Features

* Create CODEOWNERS ([#40](https://www.github.com/googleapis/python-firestore/issues/40)) ([a0cbf40](https://www.github.com/googleapis/python-firestore/commit/a0cbf403fe88f07c83bec81f275ac168be573e93))


### Bug Fixes

* **firestore:** fix get and getall method of transaction ([#16](https://www.github.com/googleapis/python-firestore/issues/16)) ([de3aca0](https://www.github.com/googleapis/python-firestore/commit/de3aca0e78b68f66eb76bc679c6e95b0746ad590))
* Update team to be in correct org ([#43](https://www.github.com/googleapis/python-firestore/issues/43)) ([bef5a3a](https://www.github.com/googleapis/python-firestore/commit/bef5a3af4613b5f9d753bb6f45275e480e4bb301))
* **firestore:** fix lint ([#48](https://www.github.com/googleapis/python-firestore/issues/48)) ([7fa00c4](https://www.github.com/googleapis/python-firestore/commit/7fa00c49dc3fab1d687fff9246f3e5ff0682cac0))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lint check fails on master

3 participants