Skip to content

fix: reseed for each auto id on 3.6 to avoid collisions #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crwilcox merged 6 commits into from
Jul 7, 2021
Merged

fix: reseed for each auto id on 3.6 to avoid collisions #388

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
814f04b
fix: Fixes #346 by reseeding for each auto id using a threadsafe uuid
crwilcox Jul 2, 2021
6524b10
fix: whitespace
crwilcox Jul 2, 2021
11915fc
Update base_collection.py
crwilcox Jul 3, 2021
2c991dc
fix: patch only need for 3.6
crwilcox Jul 3, 2021
13fa8f1
refactor: simplify seeding
crwilcox Jul 6, 2021
ed77192
chore: format
crwilcox Jul 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions google/cloud/firestore_v1/base_collection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

"""Classes for representing collections for the Google Cloud Firestore API."""
import random
import sys

from google.api_core import retry as retries # type: ignore

Expand Down Expand Up @@ -455,6 +456,12 @@ def _auto_id() -> str:
str: A 20 character string composed of digits, uppercase and
lowercase and letters.
"""
if sys.version_info < (3, 7):
# TODO: remove when 3.6 support is discontinued.
# On python 3.6, random will provide the same results when forked. Reseed
# on each iteration to avoid collisions.
random.seed()

return "".join(random.choice(_AUTO_ID_CHARS) for _ in range(20))


Expand Down