fix: update type hint for async_collection.document() to AsyncDocumen…#370
Merged
gcf-merge-on-green[bot] merged 5 commits intogoogleapis:masterfrom Jun 16, 2021
Merged
Conversation
craiglabenz
approved these changes
Jun 15, 2021
| :class:`~google.cloud.firestore_v1.document.async_document.AsyncDocumentReference`: | ||
| The child document. | ||
| """ | ||
| return super(AsyncCollectionReference, self).document(document_id) |
Contributor
There was a problem hiding this comment.
Hmm, it's unfortunate that we still use the Python 2 syntax here, though I see that's the pattern across the library and you were just following it. Nothing to do here except collectively shrug our shoulders.
Contributor
There was a problem hiding this comment.
You are welcome to go through and refactor this. This is less a choice and more a fact that this library evolved from Py2/3 compliant code and we didn't refactor more than necessary to use new features really (AsyncIO, f strings, etc)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tReference
Fixes #369 🦕