Skip to content

fix: harden version data gathering against DistributionNotFound #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crwilcox merged 2 commits into from
Oct 6, 2020
Merged

fix: harden version data gathering against DistributionNotFound #212

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5a269b
fix: harden version data gathering against DistributionNotFound
crwilcox Oct 6, 2020
38e9034
fix: lint
crwilcox Oct 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions google/cloud/firestore_v1/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,13 @@

"""Python idiomatic client for Google Cloud Firestore."""

from pkg_resources import get_distribution

__version__ = get_distribution("google-cloud-firestore").version
import pkg_resources

try:
__version__ = pkg_resources.get_distribution("google-cloud-firestore").version
except pkg_resources.DistributionNotFound:
__version__ = None

from google.cloud.firestore_v1 import types
from google.cloud.firestore_v1._helpers import GeoPoint
Expand Down