Skip to content

Comments

feat: partition queries#210

Merged
chrisrossi merged 2 commits intogoogleapis:masterfrom
chrisrossi:feat-partition-query
Oct 6, 2020
Merged

feat: partition queries#210
chrisrossi merged 2 commits intogoogleapis:masterfrom
chrisrossi:feat-partition-query

Conversation

@chrisrossi
Copy link
Contributor

@chrisrossi chrisrossi commented Oct 2, 2020

Implement the new partition queries feature for Firestore.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 2, 2020
Copy link

@cguardia cguardia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

constraints of the query that produced this partition.

Args:
query (BaseQuery): The original query that is a partition of.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original query that this is a partition of?

the beginning of the result set.
end_at (Optional[~google.cloud.firestore_v1.document.DocumentSnapshot]):
Cursor for first query result after the last result included in the
partition. If `None`, the partitions runs to the end of the result set.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/partitions/partition/

Implement the new partition queries feature for Firestore.
@chrisrossi chrisrossi force-pushed the feat-partition-query branch from 86c9ee7 to 6ebba12 Compare October 5, 2020 20:33
@chrisrossi chrisrossi changed the title WIP: Partition queries feat: partition queries Oct 5, 2020
@chrisrossi chrisrossi merged commit 4f75a75 into googleapis:master Oct 6, 2020
@chrisrossi chrisrossi deleted the feat-partition-query branch October 6, 2020 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants