Skip to content

Comments

[CHANGE ME] Re-generated to pick up changes from synthtool.#143

Closed
yoshi-automation wants to merge 7 commits intomasterfrom
autosynth-synthtool
Closed

[CHANGE ME] Re-generated to pick up changes from synthtool.#143
yoshi-automation wants to merge 7 commits intomasterfrom
autosynth-synthtool

Conversation

@yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/4be218b6-dac7-413a-9b70-c61c140820cb/targets

  • To automatically regenerate this PR, check this box.

Source-Link: googleapis/synthtool@4f8f5dc
Source-Link: googleapis/synthtool@bfcdbe0
Source-Link: googleapis/synthtool@39b527a
Source-Link: googleapis/synthtool@5dfda56
Source-Link: googleapis/synthtool@ee7506d
Source-Link: googleapis/synthtool@f07cb44

        autosynth cannot find the source of changes triggered by earlier changes in this
        repository, or by version upgrades to tools such as linters.
* feat(python-library): changes to docs job

* migrate to Trampoline V2
* add docs-presubmit job
* create docfx yaml files and upload them to another bucket

* remove redundant envvars

Source-Author: Takashi Matsuo <tmatsuo@google.com>
Source-Date: Wed Jul 29 16:15:18 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: f07cb4446192952f19be3056957f56d180586055
Source-Link: googleapis/synthtool@f07cb44
This reverts commit f07cb4446192952f19be3056957f56d180586055.

Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Source-Date: Wed Jul 29 17:33:57 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: ee7506d15daa3873accfff9430eff7e3953f0248
Source-Link: googleapis/synthtool@ee7506d
* feat(python-library): changes to docs job

* migrate to Trampoline V2
* add docs-presubmit job
* create docfx yaml files and upload them to another bucket

* remove redundant envvars

* add a failing test first

* fix TemplateSyntaxError: Missing end of comment tag

* serving_path is not needed any more

* use `raw` to make jinja happy

Source-Author: Takashi Matsuo <tmatsuo@google.com>
Source-Date: Thu Jul 30 12:44:02 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 5dfda5621df45b71b6e88544ebbb53b1a8c90214
Source-Link: googleapis/synthtool@5dfda56
Source-Author: Takashi Matsuo <tmatsuo@google.com>
Source-Date: Thu Jul 30 18:26:35 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 39b527a39f5cd56d4882b3874fc08eed4756cebe
Source-Link: googleapis/synthtool@39b527a
Source-Author: Takashi Matsuo <tmatsuo@google.com>
Source-Date: Fri Jul 31 16:17:13 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: bfcdbe0da977b2de6c1c0471bb6dc2f1e13bf669
Source-Link: googleapis/synthtool@bfcdbe0
This should fix build failures in python-bigquery.
Example:
googleapis/python-bigquery#205

* also add a comment

Source-Author: Takashi Matsuo <tmatsuo@google.com>
Source-Date: Mon Aug 3 15:08:00 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 4f8f5dc24af79694887385015294e4dbb214c352
Source-Link: googleapis/synthtool@4f8f5dc
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 5, 2020
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not merge until we resolve the dropped import issue.

import google.api_core.gapic_v1.routing_header
import google.api_core.grpc_helpers
import google.api_core.page_iterator
import google.api_core.path_template
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potentially breaking change: see googleapis/python-storage#226.

@tseaver tseaver added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 5, 2020
tseaver added a commit that referenced this pull request Aug 19, 2020
Re-add 'google.api_core.path_template' import lost in generation.

Closes #154.
Closes #141.
Closes #142.
Closes #143.
@tseaver tseaver closed this in #155 Aug 19, 2020
tseaver added a commit that referenced this pull request Aug 19, 2020
Re-add 'google.api_core.path_template' import lost in generation.

Closes #154.
Closes #141.
Closes #142.
Closes #143.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. context: partial do not merge Indicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants