[CHANGE ME] Re-generated to pick up changes from self.#141
Closed
yoshi-automation wants to merge 1 commit intomasterfrom
Closed
[CHANGE ME] Re-generated to pick up changes from self.#141yoshi-automation wants to merge 1 commit intomasterfrom
yoshi-automation wants to merge 1 commit intomasterfrom
Conversation
autosynth cannot find the source of changes triggered by earlier changes in this
repository, or by version upgrades to tools such as linters.
tseaver
reviewed
Aug 5, 2020
| import google.api_core.gapic_v1.routing_header | ||
| import google.api_core.grpc_helpers | ||
| import google.api_core.page_iterator | ||
| import google.api_core.path_template |
Contributor
There was a problem hiding this comment.
This is a potentially breaking change: it relies on sombebody else to have imported it before we use it below. See: googleapis/python-storage#226
@software-dov Is this a known bug in the generator?
There was a problem hiding this comment.
No, this is not a known issue in the generator. I'll file an issue to add it back under the correct circumstances.
Tracked by googleapis/gapic-generator-python#565
tseaver
suggested changes
Aug 5, 2020
Contributor
tseaver
left a comment
There was a problem hiding this comment.
Do not merge until we resolve the dropped import issue.
tseaver
added a commit
that referenced
this pull request
Aug 19, 2020
tseaver
added a commit
that referenced
this pull request
Aug 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was generated using Autosynth. 🌈
Synth log will be available here:
https://source.cloud.google.com/results/invocations/4be218b6-dac7-413a-9b70-c61c140820cb/targets