fix(pubsub): add 'StreamingPullManager._should_terminate'.#9335
Merged
tseaver merged 1 commit intogoogleapis:masterfrom Oct 1, 2019
tseaver:pubsub-add-should_terminate
Merged
fix(pubsub): add 'StreamingPullManager._should_terminate'.#9335tseaver merged 1 commit intogoogleapis:masterfrom tseaver:pubsub-add-should_terminate
tseaver merged 1 commit intogoogleapis:masterfrom
tseaver:pubsub-add-should_terminate
Conversation
Toward clean shutdown of the subscriber's background thread. See: #8616.
plamut
approved these changes
Sep 29, 2019
Contributor
plamut
left a comment
There was a problem hiding this comment.
LGTM.
It does not fix the issue yet, but the PR description does not claim that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toward clean shutdown of the subscriber's background thread.
See: #8616.