feat(bigquery): add support for custom QueryJobConfig in BigQuery.cursor.execute method#9278
Conversation
942cfff to
dd170ac
Compare
dd170ac to
7d23584
Compare
…ute cursor method
|
Thanks for feedback @plamut . I've applied changes suggested by you however still waiting for Kokoro check. |
|
Kokoro - Recommender check has failed however logs are empty. @plamut do you know maybe why it failed? I have no clue what is the reason. |
|
@TobKed Seems like flakiness, saw the same on a few other PRs as well. I will try restarting the jobs. Update: Actually, it seems to be a real issue in the Recommender library, not just flakiness. It currently happens on all PRs, and it's not related to the changes made here. |
plamut
left a comment
There was a problem hiding this comment.
LGTM, a custom job config indeed changes the SQL mode for the job on the backend.
|
@plamut thanks for feedback! Good luck with fixing Kokoro :) |
tswast
left a comment
There was a problem hiding this comment.
LGTM. I'm a bit concerned about deviating from the DB-API spec for execute(), but I see we already deviate due to job_id.
My change allows to support
use_legacy_sql.