Firestore: Allow snapshot cursors from other collections for collection group queries.#8882
Merged
tseaver merged 1 commit intogoogleapis:masterfrom Aug 1, 2019
tseaver:8633-firestore-collection-group-cursors
Merged
Firestore: Allow snapshot cursors from other collections for collection group queries.#8882tseaver merged 1 commit intogoogleapis:masterfrom tseaver:8633-firestore-collection-group-cursors
tseaver merged 1 commit intogoogleapis:masterfrom
tseaver:8633-firestore-collection-group-cursors
Conversation
Contributor
Author
|
Datastore, Phishing Protection, and Translation jobs fail due to Kokoro-internal glitch: "Cannot check out non-mergeable pull request as if merged." |
|
@tseaver, what does it mean, supersedes? Second time you're taking my PR, rewriting something a little, and pushing your own. How should I understand that? |
gopherbot
pushed a commit
to googleapis/google-cloud-go
that referenced
this pull request
Dec 4, 2019
CollectionGroup queries should be able to use snapshot cursors from other collections. This is allowed by the API but is prevented by the client library currently. See similar fix in the python client here: googleapis/google-cloud-python#8882 Fixes #1659 Change-Id: I71882e5981b97484a8222b47225a75d6da72fc6d Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/49150 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: BenWhitehead <benwhitehead@google.com> Reviewed-by: Jean de Klerk <deklerk@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8633.
Supersedes #8810.