Skip to content

Comments

Firestore: Add GAPIC client for Admin V1.#8667

Merged
tseaver merged 2 commits intogoogleapis:masterfrom
tseaver:8664-firestore-synth-admin-v1-client
Jul 23, 2019
Merged

Firestore: Add GAPIC client for Admin V1.#8667
tseaver merged 2 commits intogoogleapis:masterfrom
tseaver:8664-firestore-synth-admin-v1-client

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Jul 12, 2019

Blocked on the change to the Firestore admin GAPIC config propposed
in googleapis/googleapis#566

Closes #8664.

Requires the change to the Firestore admin GAPIC config propposed
in googleapis/googleapis#566

Closes #8664.
@tseaver tseaver added do not merge Indicates a pull request not ready for merge, due to either quality or timing. api: firestore Issues related to the Firestore API. codegen labels Jul 12, 2019
@tseaver tseaver requested review from BenWhitehead and crwilcox July 12, 2019 18:53
@tseaver tseaver requested a review from frankyn as a code owner July 12, 2019 18:53
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 12, 2019
@tseaver
Copy link
Contributor Author

tseaver commented Jul 12, 2019

I don't have access to view the failed Talent job on Kokoro.

The WebRisk failure is due to Github rate limiting, tracked in #8668.

@tseaver tseaver added external This issue is blocked on a bug with the actual product. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. external This issue is blocked on a bug with the actual product. labels Jul 16, 2019
@tseaver
Copy link
Contributor Author

tseaver commented Jul 22, 2019

Synth re-run without manual generation after the close ("merge" by tweaking upstream) of googleapis/googleapis#566.

@tseaver
Copy link
Contributor Author

tseaver commented Jul 22, 2019

@BenWhitehead, @crwilcox, @frankyn OK, this one is ready for review.

@tseaver tseaver merged commit 3bd18cb into googleapis:master Jul 23, 2019
@tseaver tseaver deleted the 8664-firestore-synth-admin-v1-client branch July 23, 2019 17:26
parthea pushed a commit that referenced this pull request Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement. codegen

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Firestore: Generate Admin V1 Client.

3 participants