Skip to content

BigQuery: Fix unit tests for new versions of fastparquet and pytest#8553

Merged
tswast merged 2 commits intogoogleapis:masterfrom
tswast:bq-tests
Jul 1, 2019
Merged

BigQuery: Fix unit tests for new versions of fastparquet and pytest#8553
tswast merged 2 commits intogoogleapis:masterfrom
tswast:bq-tests

Conversation

@tswast
Copy link
Contributor

@tswast tswast commented Jul 1, 2019

fastparquet is an optional dependency, and is redundant with pyarrow. It is not necessary to include in in the [all] extras. This avoids an issue where the fastparquet dependency pulls in a pre-release version of numpy.

Closes #8549

Version 5.0.0 of pytest modifies the behavior of str on the pytest.raises() context manager. Update the tests to call str on the actual exception (context.value), instead.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 1, 2019
@tswast tswast marked this pull request as ready for review July 1, 2019 21:44
@tswast tswast requested review from a team and crwilcox July 1, 2019 21:44
@tswast tswast added api: bigquery Issues related to the BigQuery API. testing labels Jul 1, 2019
@tswast tswast mentioned this pull request Jul 1, 2019
@tswast tswast requested a review from steffnay July 1, 2019 22:06
@tswast
Copy link
Contributor Author

tswast commented Jul 1, 2019

System test failures test_list_datasets and test_list_datasets_w_project appear to be flakes.

@tswast tswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 1, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 1, 2019
@tswast
Copy link
Contributor Author

tswast commented Jul 1, 2019

There's an ongoing issue on the BigQuery backend for dataset.list. Those are the only test failures.

@tswast tswast merged commit 01f54a9 into googleapis:master Jul 1, 2019
@tswast tswast deleted the bq-tests branch July 1, 2019 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement. testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BigQuery: numpy release breaks Python 2.7 unit tests

4 participants