Firestore: use correct environment variable to guard the 'system' part.#7912
Merged
tseaver merged 2 commits intogoogleapis:masterfrom May 17, 2019
tseaver:firestore-nox-correct-systest-envvar
Merged
Firestore: use correct environment variable to guard the 'system' part.#7912tseaver merged 2 commits intogoogleapis:masterfrom tseaver:firestore-nox-correct-systest-envvar
tseaver merged 2 commits intogoogleapis:masterfrom
tseaver:firestore-nox-correct-systest-envvar
Conversation
busunkim96
reviewed
May 9, 2019
Contributor
Author
|
@busunkim96 I fixed the |
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
…t. (#7912) * Use the correct environment variable to guard the 'system' part. * Restore 'docs' session via synth.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firestore's system tests use a different environment variable (because firestore vs. datastore hysterical raisins).