Skip to content

use fqdn for gce metadata endpoint #7520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tseaver merged 2 commits into from
Mar 19, 2019
Merged

use fqdn for gce metadata endpoint #7520

tseaver merged 2 commits into from
Mar 19, 2019

Conversation

@rsalmond
Copy link
Contributor

@rsalmond rsalmond commented Mar 15, 2019

Fixes #7517.

@rsalmond rsalmond requested a review from crwilcox as a code owner March 15, 2019 22:27
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 15, 2019
crwilcox
crwilcox reviewed Mar 15, 2019
View reviewed changes
@tseaver tseaver merged commit a9a3f6a into googleapis:master Mar 19, 2019
@tseaver tseaver added the api: logging Issues related to the Cloud Logging API. label Mar 19, 2019
@tseaver
Copy link
Contributor

tseaver commented Mar 19, 2019

Thanks very much for the patch!

parthea pushed a commit that referenced this pull request Nov 24, 2025
@rsalmond @tseaver
Use FQDN for GCE metadata endpoint. (#7520)
c3818d6 
Closes #7517.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@crwilcox crwilcox crwilcox left review comments

@tseaver tseaver tseaver approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rsalmond @tseaver @crwilcox @googlebot