Skip to content

Comments

Firestore: implement listen conformance#6935

Merged
tseaver merged 2 commits intogoogleapis:masterfrom
mcdonc:6533-implement-listen-conformance
Dec 18, 2018
Merged

Firestore: implement listen conformance#6935
tseaver merged 2 commits intogoogleapis:masterfrom
mcdonc:6533-implement-listen-conformance

Conversation

@mcdonc
Copy link
Contributor

@mcdonc mcdonc commented Dec 17, 2018

Fixes two bugs in the watch code:

  • always-truthiness of protobufs foiled a delete/remove document case.
  • change map would receive keys that were document snapshots instead of document names sometimes,
    foiling the reset code.

Closes #6533

@mcdonc mcdonc requested a review from crwilcox as a code owner December 17, 2018 21:18
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 17, 2018
@tseaver tseaver changed the title implement listen conformance Firestore: implement listen conformance Dec 17, 2018
@tseaver tseaver added testing api: firestore Issues related to the Firestore API. labels Dec 17, 2018
@tseaver
Copy link
Contributor

tseaver commented Dec 18, 2018

@tseaver tseaver merged commit 6b7d6cf into googleapis:master Dec 18, 2018
parthea pushed a commit that referenced this pull request Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement. testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants