Skip to content

Storage: add missing call to batch.begin() in example.#6932

Merged
tseaver merged 1 commit intogoogleapis:masterfrom
sorced-jim:patch-2
Dec 17, 2018
Merged

Storage: add missing call to batch.begin() in example.#6932
tseaver merged 1 commit intogoogleapis:masterfrom
sorced-jim:patch-2

Conversation

@sorced-jim
Copy link
Contributor

This should have an email that matches a CLA.

@sorced-jim sorced-jim requested a review from crwilcox as a code owner December 16, 2018 22:30
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 16, 2018
@tseaver tseaver changed the title Add missing call to batch.begin() in example. Storage: add missing call to batch.begin() in example. Dec 17, 2018
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although not really required for the example (begin is more of a hook for the Transaction subclass), it does show usage, which would prevent reuse of a previously begun batch.

@tseaver tseaver added api: datastore Issues related to the Datastore API. type: docs Improvement to the documentation for an API. labels Dec 17, 2018
@tseaver tseaver merged commit db75dda into googleapis:master Dec 17, 2018
@tseaver
Copy link
Contributor

tseaver commented Dec 17, 2018

Thanks for the patch, @sorced-jim!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement. type: docs Improvement to the documentation for an API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants