Skip to content

Comments

Firestore: enable use of 'WriteBatch' as a context manager.#6912

Merged
tseaver merged 4 commits intogoogleapis:masterfrom
tseaver:6548-firestore-batch_context_mgr
Dec 17, 2018
Merged

Firestore: enable use of 'WriteBatch' as a context manager.#6912
tseaver merged 4 commits intogoogleapis:masterfrom
tseaver:6548-firestore-batch_context_mgr

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Dec 12, 2018

Closes #6548.

@tseaver tseaver added the api: firestore Issues related to the Firestore API. label Dec 12, 2018
@tseaver tseaver requested a review from crwilcox December 12, 2018 22:13
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 12, 2018
@tseaver tseaver requested a review from mcdonc December 12, 2018 22:13
@tseaver
Copy link
Contributor Author

tseaver commented Dec 13, 2018

@crwilcox Failed systests are all due to quota issues in the watch tests.

Copy link
Contributor

@mcdonc mcdonc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tseaver tseaver merged commit 54e87e1 into googleapis:master Dec 17, 2018
@tseaver tseaver deleted the 6548-firestore-batch_context_mgr branch December 17, 2018 21:48
parthea pushed a commit that referenced this pull request Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants